BF: Fix regression in continueRoutine behaviour #2680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a regression in version 3.2.0 in which setting
continueRoutine = False
no longer has an effect in Builder code components (because the Builder-generated code overrides the custom code by always resettingcontinueRoutine = True
immediately before the routine begins). All this pull request does its shiftcontinueRoutine = True
to be first rather than last in the order of execution prior to a routine, so that custom code can override it.For recent bug reports, see:
https://discourse.psychopy.org/t/continueroutine-false-in-begin-routine-tab-has-no-effect/9801
and for previous development history, see:
#1143