Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Double buffer panels/fix high DPI error on Windows <8.1 #2820

Merged
merged 2 commits into from
Mar 2, 2020
Merged

BF: Double buffer panels/fix high DPI error on Windows <8.1 #2820

merged 2 commits into from
Mar 2, 2020

Conversation

mdcutone
Copy link
Member

@mdcutone mdcutone commented Mar 1, 2020

When creating a new loop or collapsing component panes, either the control flickers when moving the mouse around or only partially redraws. This PR double buffers the controls providing a smoother visual experience (on Windows at least).

Also includes a bugfix for #2818.

…ng and partial redraws (on Windows at least).
@coveralls
Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage increased (+0.03%) to 48.68% when pulling 48710a5 on mdcutone:builder-fixes into 3e8adf5 on psychopy:master.

@mdcutone mdcutone changed the title BF: Double buffer the components and flow panel to eliminate flickering BF: Double buffer panels/fix high DPI error on Windows <8.1 Mar 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #2820 into master will increase coverage by <.01%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2820      +/-   ##
==========================================
+ Coverage   44.45%   44.45%   +<.01%     
==========================================
  Files         242      242              
  Lines       45030    45034       +4     
  Branches     7650     7650              
==========================================
+ Hits        20018    20020       +2     
+ Misses      22955    22953       -2     
- Partials     2057     2061       +4
Impacted Files Coverage Δ
psychopy/app/_psychopyApp.py 36.59% <0%> (-0.14%) ⬇️
psychopy/app/builder/builder.py 52.18% <100%> (+0.03%) ⬆️
psychopy/app/builder/flow.py 35.99% <100%> (+0.1%) ⬆️
psychopy/visual/textbox/__init__.py 43.6% <0%> (ø) ⬆️
psychopy/app/builder/dialogs/dlgsConditions.py 7.51% <0%> (ø) ⬆️
...ychopy/localization/generateTranslationTemplate.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e8adf5...48710a5. Read the comment docs.

@peircej peircej merged commit 55e103a into psychopy:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants