ENH: Allow Brush to draw without holding down the mouse button#2980
Merged
peircej merged 1 commit intopsychopy:masterfrom Jul 26, 2020
Merged
ENH: Allow Brush to draw without holding down the mouse button#2980peircej merged 1 commit intopsychopy:masterfrom
peircej merged 1 commit intopsychopy:masterfrom
Conversation
Also exposed this functionality via the Builder component UI. *NB* this has been implemented only for PsychoPy. Equivalent changes would need to be made for PsychoJS. Made in response to this forum topic: https://discourse.psychopy.org/t/creating-a-mouse-trail-for-trail-tracing/15138
Codecov Report
@@ Coverage Diff @@
## master #2980 +/- ##
==========================================
- Coverage 43.09% 43.07% -0.02%
==========================================
Files 256 256
Lines 48307 48327 +20
Branches 8196 8201 +5
==========================================
- Hits 20818 20817 -1
- Misses 25342 25361 +19
- Partials 2147 2149 +2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently to draw with the Brush stimulus requires holding down the mouse button. Allowing drawing without a button press can be useful, and may be easier with trackpads, touch interfaces, and so on.
Also exposed this functionality via the Builder component UI.
NB this has been implemented only for PsychoPy. Equivalent changes would need to be made for PsychoJS. Any volunteers?
Made in response to this forum topic:
https://discourse.psychopy.org/t/creating-a-mouse-trail-for-trail-tracing/15138