BF: Fix to textbox colors #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 16, 2020 13:30
…h colors being innaccurate in some spaces
…lems with colors being innaccurate in some spaces" This reverts commit 193ed81
…or class is in use
|
@peircej so there was already code in there to draw the caret even when no character vertices are available, it was just calculating default vertices wrong so the width became 0. The position isn't quite right still, but it's close enough for now as it'll all change when the Size/Position classes are in anyway. |
peircej
pushed a commit
that referenced
this pull request
Oct 22, 2020
* BF: Use Color class to handle textbox pallette, bypasses problems with colors being innaccurate in some spaces * Revert "BF: Use Color class to handle textbox pallette, bypasses problems with colors being innaccurate in some spaces" This reverts commit 193ed81 * BF: Remove Textbox color change on selection, will reinstate when Color class is in use * BF: Caret now appears when textbox is empty Co-authored-by: Todd <TEParsons>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Color class as a one-off fix to be over-written when the class is fully implemented