Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BF: If textbox is only editable on screen, give it focus by default, … #3269

Merged
merged 2 commits into from
Nov 12, 2020
Merged

BF: If textbox is only editable on screen, give it focus by default, … #3269

merged 2 commits into from
Nov 12, 2020

Conversation

TEParsons
Copy link
Contributor

…fixes #3267

@coveralls
Copy link

coveralls commented Nov 6, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 46.495% when pulling 4d66560 on TEParsons:_textboxFocus into 673830b on psychopy:master.

TEParsons pushed a commit to TEParsons/psychopy that referenced this pull request Nov 9, 2020
RF: Set textbox editable on change to autoDraw, not on init, meaning …
cec0c73 
…it is only editable when on screen. Fixes psychopy#3267, overrides psychopy#3269.
@TEParsons TEParsons mentioned this pull request Nov 9, 2020
Merged
@peircej peircej merged commit 960214e into psychopy:master Nov 12, 2020
peircej pushed a commit that referenced this pull request Nov 12, 2020
@TEParsons @peircej
BF: If textbox is only editable on screen, give it focus by default, … (
12d5b42 
#3269)

* BF: If textbox is only editable on screen, give it focus by default, fixes #3267

* BF: Remove print statement

Co-authored-by: Todd <TEParsons>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Textbox not editable if multiple textbox components used
3 participants
@TEParsons @coveralls @peircej