Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: move the BeforeExperiment JS code to come before the first function #3289

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

peircej
Copy link
Member

@peircej peircej commented Nov 12, 2020

This is essential to make sure that it can be used for importing

This is essential to make sure that it can be used for importing
@coveralls
Copy link

coveralls commented Nov 12, 2020

Coverage Status

Coverage increased (+0.003%) to 46.513% when pulling 72a055a on peircej:hotfix-JSpreExpLoading into 960214e on psychopy:master.

@codecov-io
Copy link

Codecov Report

Merging #3289 (72a055a) into master (d8b0963) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3289   +/-   ##
=======================================
  Coverage   42.68%   42.68%           
=======================================
  Files         261      261           
  Lines       51063    51072    +9     
  Branches     8816     8819    +3     
=======================================
+ Hits        21798    21802    +4     
- Misses      27060    27064    +4     
- Partials     2205     2206    +1     
Impacted Files Coverage Δ
psychopy/experiment/flow.py 63.06% <ø> (ø)
psychopy/experiment/_experiment.py 52.34% <100.00%> (+0.25%) ⬆️
psychopy/visual/window.py 60.93% <0.00%> (-0.22%) ⬇️
psychopy/monitors/calibTools.py 37.37% <0.00%> (-0.18%) ⬇️
psychopy/visual/backends/pygletbackend.py 51.48% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b0963...72a055a. Read the comment docs.

@peircej peircej merged commit 2d3683d into psychopy:master Nov 12, 2020
@peircej peircej deleted the hotfix-JSpreExpLoading branch November 12, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants