Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fixing crash when JS/Py component filter is not Any or Both #3649

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

TEParsons
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #3649 (7d617b3) into release (0419007) will increase coverage by 0.01%.
The diff coverage is 88.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #3649      +/-   ##
===========================================
+ Coverage    43.20%   43.22%   +0.01%     
===========================================
  Files          267      267              
  Lines        52759    52778      +19     
  Branches      9103     9103              
===========================================
+ Hits         22794    22812      +18     
- Misses       27641    27642       +1     
  Partials      2324     2324              
Impacted Files Coverage Δ
psychopy/app/builder/builder.py 47.14% <0.00%> (ø)
psychopy/experiment/components/pump/__init__.py 7.69% <0.00%> (-0.13%) ⬇️
...sychopy/experiment/components/aperture/__init__.py 83.63% <100.00%> (+0.30%) ⬆️
psychopy/experiment/components/brush/__init__.py 100.00% <100.00%> (ø)
psychopy/experiment/components/code/__init__.py 90.56% <100.00%> (ø)
psychopy/experiment/components/dots/__init__.py 95.08% <100.00%> (+0.08%) ⬆️
...y/experiment/components/emotiv_marking/__init__.py 90.00% <100.00%> (+0.16%) ⬆️
...py/experiment/components/emotiv_record/__init__.py 100.00% <100.00%> (ø)
.../experiment/components/envelopegrating/__init__.py 83.51% <100.00%> (+0.18%) ⬆️
...chopy/experiment/components/eyetracker/__init__.py 25.67% <100.00%> (+1.01%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0419007...7d617b3. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 26, 2021

Coverage Status

Coverage increased (+0.02%) to 47.073% when pulling 7d617b3 on TEParsons:_JSfilter into 0419007 on psychopy:release.

@peircej peircej merged commit fbc0c98 into psychopy:release Mar 4, 2021
@TEParsons TEParsons deleted the _JSfilter branch May 5, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants