BF: handle pre-2021.1 Slider styles in 2021.1.3+ #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slider styles still not handling the old style specification correctly. Fixes: 1. to allow the experiment to load at all we need to check if we have a 'fixedList' valType with only a string rather than list, and convert to string if needed in `Experiment._getParamFromXML()` 2. to allow the JS script to compile we need to handle either a list or a string at the compile step in `SliderComponent.writeInitCodeJS()` Another approach would have been to make a conversion *away* from the list (into the new format) in (1.) so that (2.) wasn't needed but that would have broken compatibility more for experiments being shared back to older studies
Codecov Report
@@ Coverage Diff @@
## release #3665 +/- ##
========================================
Coverage 43.24% 43.24%
========================================
Files 267 267
Lines 52795 52800 +5
Branches 9107 9108 +1
========================================
+ Hits 22829 22832 +3
- Misses 27646 27648 +2
Partials 2320 2320
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slider styles still not handling the old style specification correctly.
Fixes:
a 'fixedList' valType with only a string rather than list, and convert
to string if needed in
Experiment._getParamFromXML()or a string at the compile step in
SliderComponent.writeInitCodeJS()Another approach would have been to make a conversion away from the
list (into the new format) in (1.) so that (2.) wasn't needed but that
would have broken compatibility more for experiments being shared back
to older studies