Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: fixed the bug that setSound() incorrectly truncate the sound file #3689

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

yh-luo
Copy link
Contributor

@yh-luo yh-luo commented Mar 18, 2021

Details in #3688

  • fix stopTime in sounddevice backend

  • fix stopTime in ptb backend

* fix stopTime in sounddevice backend

* fix stopTime in ptb backend
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #3689 (1b536af) into release (c67b0cd) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #3689   +/-   ##
========================================
  Coverage    43.23%   43.24%           
========================================
  Files          267      267           
  Lines        52799    52799           
  Branches      9108     9108           
========================================
+ Hits         22829    22832    +3     
+ Misses       27649    27647    -2     
+ Partials      2321     2320    -1     
Impacted Files Coverage Δ
psychopy/sound/backend_ptb.py 0.00% <0.00%> (ø)
psychopy/sound/backend_sounddevice.py 61.39% <100.00%> (ø)
psychopy/tools/wizard.py 72.78% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67b0cd...1b536af. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 18, 2021

Coverage Status

Coverage increased (+0.004%) to 47.085% when pulling 1b536af on yh-luo:fix_truncated_sound into c67b0cd on psychopy:release.

@peircej peircej requested a review from mdcutone March 19, 2021 10:43
@mdcutone
Copy link
Member

I wonder if this relates to another problem we've had. Cool if this fixes things.

@peircej peircej merged commit 49cf52e into psychopy:release Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants