Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fixes #4135 - labels now work in DlgFromDict #4137

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

gjcooper
Copy link
Contributor

In the most recent release version if you pass at labels argument to the
DlgFromDict class then when you return from the dialog it raises a KeyError.

This was caused by the field name in the dialog no longer matching the
dictionary key which is passed to the init function. The fix was to store
the labels argument as an attribute on the dialog object to test against
when the dialog box returns.

In the most recent release version if you pass at labels argument to the
DlgFromDict class then when you return from the dialog it raises a KeyError.

This was caused by the field name in the dialog no longer matching the
dictionary key which is passed to the __init__ function. The fix was to store
the labels argument as an attribute on the dialog object to test against
when the dialog box returns.
@peircej peircej merged commit e759c3f into psychopy:release Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants