Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: tweak PsychoJS lib artefact list and file name collation in app/runner #4153

Merged
merged 1 commit into from
Jul 21, 2021
Merged

BF: tweak PsychoJS lib artefact list and file name collation in app/runner #4153

merged 1 commit into from
Jul 21, 2021

Conversation

thewhodidthis
Copy link
Contributor

@peircej Have the for loop in Runner.getPsychoJS() care about lib version and file extension rather than module name, closes #4152 馃

@peircej
Copy link
Member

peircej commented Jul 21, 2021

@thewhodidthis thewhodidthis changed the title app/runner: tweak PsychoJS lib artefact list and file name collation BF: tweak PsychoJS lib artefact list and file name collation in app/runner Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #4153 (21e1e18) into release (28f9dc9) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release    #4153      +/-   ##
===========================================
- Coverage    35.68%   35.67%   -0.01%     
===========================================
  Files          288      288              
  Lines        56764    56764              
  Branches      9674     9674              
===========================================
- Hits         20255    20251       -4     
- Misses       34531    34536       +5     
+ Partials      1978     1977       -1     
Impacted Files Coverage 螖
psychopy/app/runner/runner.py 0.00% <0.00%> (酶)
psychopy/visual/movie3.py 60.22% <0.00%> (-1.49%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 28f9dc9...21e1e18. Read the comment docs.

@peircej peircej merged commit fc8415e into psychopy:release Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lib list entries in Runner.getPsychoJS() need updating for PsychoJS latest
2 participants