Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: mic.bank values from Builder #4163

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Conversation

TEParsons
Copy link
Contributor

  1. Accept 'None' as a synonym for False when mic.bank is called
  2. Don't try to unpack values from mic.bank in Builder when transcription is disabled

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #4163 (afc009f) into release (fc8415e) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #4163   +/-   ##
========================================
  Coverage    35.67%   35.68%           
========================================
  Files          288      288           
  Lines        56764    56770    +6     
  Branches      9674     9676    +2     
========================================
+ Hits         20251    20257    +6     
+ Misses       34536    34534    -2     
- Partials      1977     1979    +2     
Impacted Files Coverage Δ
psychopy/sound/microphone.py 28.95% <0.00%> (-0.20%) ⬇️
...chopy/experiment/components/microphone/__init__.py 82.64% <50.00%> (-0.61%) ⬇️
psychopy/visual/movie3.py 61.71% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc8415e...afc009f. Read the comment docs.

@peircej peircej merged commit 1d1b047 into psychopy:release Jul 26, 2021
@TEParsons TEParsons deleted the _micCharlotteBug branch December 22, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants