Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Remove unecessary namespace check on code snippets #4193

Closed
wants to merge 4 commits into from

Conversation

TEParsons
Copy link
Contributor

No description provided.

@TEParsons TEParsons marked this pull request as ready for review August 4, 2021 07:56
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #4193 (b60016c) into release (e2a87c3) will increase coverage by 0.00%.
The diff coverage is 12.50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #4193   +/-   ##
========================================
  Coverage    35.80%   35.81%           
========================================
  Files          288      288           
  Lines        56798    56805    +7     
  Branches      9661     9665    +4     
========================================
+ Hits         20337    20342    +5     
- Misses       34480    34481    +1     
- Partials      1981     1982    +1     
Impacted Files Coverage Δ
psychopy/app/builder/validators.py 29.23% <12.50%> (-0.42%) ⬇️
psychopy/visual/movie3.py 61.71% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a87c3...b60016c. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Aug 4, 2021

This pull request introduces 1 alert when merging 83a6887 into e2a87c3 - view on LGTM.com

new alerts:

  • 1 for Unused import

@TEParsons
Copy link
Contributor Author

I can't add a test for this in release as it needs #4120 to run any successfully - but once this is in and release is merged into dev I can add one in dev

@peircej
Copy link
Member

peircej commented Aug 5, 2021

@TEParsons TEParsons closed this Aug 5, 2021
TEParsons added a commit to TEParsons/psychopy that referenced this pull request Aug 5, 2021
TEParsons added a commit to TEParsons/psychopy that referenced this pull request Aug 5, 2021
@TEParsons TEParsons deleted the _varNameAlert branch July 4, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants