Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: Fix DotStim updating #4694

Merged
merged 4 commits into from
Mar 14, 2022
Merged

BF: Fix DotStim updating #4694

merged 4 commits into from
Mar 14, 2022

Conversation

TEParsons
Copy link
Contributor

fixes #4691

@TEParsons TEParsons requested a review from mdcutone March 14, 2022 10:02
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #4694 (a12f728) into release (5660025) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           release    #4694      +/-   ##
===========================================
+ Coverage    45.26%   45.28%   +0.01%     
===========================================
  Files          294      294              
  Lines        58876    58899      +23     
  Branches     10407    10411       +4     
===========================================
+ Hits         26653    26671      +18     
- Misses       29836    29846      +10     
+ Partials      2387     2382       -5     
Impacted Files Coverage Δ
psychopy/visual/dot.py 78.24% <50.00%> (+5.68%) ⬆️
psychopy/app/jobs.py 35.82% <0.00%> (-1.62%) ⬇️
psychopy/experiment/routines/_base.py 84.61% <0.00%> (-1.25%) ⬇️
psychopy/visual/window.py 62.29% <0.00%> (-0.15%) ⬇️
psychopy/monitors/getLumSeries.py 0.00% <0.00%> (ø)
psychopy/experiment/components/button/__init__.py 86.36% <0.00%> (+0.20%) ⬆️
psychopy/hardware/eyetracker.py 19.19% <0.00%> (+2.17%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mdcutone mdcutone merged commit 5af70c4 into psychopy:release Mar 14, 2022
@TEParsons TEParsons deleted the _dotAnimate branch April 29, 2022 11:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DotStim no longer animates dynamically
2 participants