BF: slider.startValue should not be setting the slider.rating during reset #4738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reset Only the markerPos should be controlled by the startValue, not the rating. If a Rating exists it implies a response has been made which it hasn't, at the time of resetting
In commit e2442db we turned off resetting the rating to startValue but didn't set it to be reset to None, which is also important!
Codecov Report
@@ Coverage Diff @@
## release #4738 +/- ##
===========================================
- Coverage 45.34% 45.33% -0.01%
===========================================
Files 294 294
Lines 58843 58844 +1
Branches 10393 10393
===========================================
- Hits 26681 26677 -4
- Misses 29778 29781 +3
- Partials 2384 2386 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the markerPos should be controlled by the startValue, not the
rating. If a Rating exists it implies a response has been made which it
hasn't, at the time of resetting