BF: if mic/transcription libs let's still offer sound components #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beforehand, if pocketsphinx failed to load (which is a bit finicky anyway) then the Sound component would not show up in Builder
…f-soft-fail-transcriptionRelease
Codecov Report
@@ Coverage Diff @@
## release #4747 +/- ##
===========================================
- Coverage 45.30% 45.27% -0.04%
===========================================
Files 294 294
Lines 58894 58903 +9
Branches 10398 10398
===========================================
- Hits 26682 26668 -14
- Misses 29836 29858 +22
- Partials 2376 2377 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beforehand, if pocketsphinx failed to load (which is a bit finicky anyway)
then the Sound component would not show up in Builder