BF/RF: Application logging overhaul #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 1, 2022 14:05
…atch more startup errors.
…ess. Some changes to `startApp`.
|
This pull request introduces 3 alerts and fixes 1 when merging 21948bb into 2a2f56d - view on LGTM.com new alerts:
fixed alerts:
|
… correct time, error is raised otherwise.
|
This pull request introduces 3 alerts and fixes 1 when merging 11a6e15 into 2a2f56d - view on LGTM.com new alerts:
fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## release #4750 +/- ##
===========================================
- Coverage 45.32% 45.31% -0.01%
===========================================
Files 294 294
Lines 58845 58861 +16
Branches 10393 10394 +1
===========================================
+ Hits 26671 26673 +2
- Misses 29793 29810 +17
+ Partials 2381 2378 -3
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
This pull request introduces 3 alerts and fixes 1 when merging a82d320 into 9fcdb76 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes previous logging 'blind-spots' in the application. Now errors that occur during GUI initialization are captured a printed to 'last_app_load.log'. Also, messages written to stdout/sterr from sub-processes also show up in that log.
I also made changes to how subprocess pipes are handled to be less implicit about their state when shutting down (better communication between main and sub-threads. This removes the 'hang' that can occur when closing down a subprocess.