BF: Fix FileNotFoundError when running tasks
#4759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2022 16:09
|
This pull request introduces 1 alert when merging ce62420 into 2a2f56d - view on LGTM.com new alerts:
|
|
How is a Builder experiment passed to the Runner without saving? It should prompt the user to save when the "Send To Runner" button is clicked, and seems to when I try |
Codecov Report
@@ Coverage Diff @@
## release #4759 +/- ##
===========================================
- Coverage 45.32% 44.73% -0.59%
===========================================
Files 294 294
Lines 58845 58871 +26
Branches 10393 10398 +5
===========================================
- Hits 26671 26338 -333
- Misses 29793 30168 +375
+ Partials 2381 2365 -16
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
TEParsons
approved these changes
Apr 7, 2022
|
This pull request introduces 1 alert when merging 09d5e21 into 9fcdb76 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Builder task is passed to runner without saving first, the task list item created uses a relative path instead of absolute which causes an unhandled exception to occur when running the file. This patch prevents this from happening by ensuring absolute paths are used when building the command for
Job.I also added a dialog box and log messages to catch errors trying to start a subprocess, made some changes to ensure the UI state is correct after such an error occurs to maintain app stability.