BF: Fix order of dataFileName and addInfoFromUrl (#4831) #5171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataFileName assignment should come after addInfoFromUrl so that URL parameters (such as participant id) can be added to the filename.
Codecov Report
@@ Coverage Diff @@
## release #5171 +/- ##
===========================================
- Coverage 45.77% 45.76% -0.01%
===========================================
Files 307 307
Lines 61670 61670
Branches 10761 10246 -515
===========================================
- Hits 28229 28225 -4
- Misses 30978 30980 +2
- Partials 2463 2465 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TEParsons
approved these changes
Oct 14, 2022
|
Thanks for this, took a minute for me to work backwards and see what we got wrong but I see it now and your fix is exactly right. I'll pull in now, thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where participant ids provided via URL parameters are not being added to the data filename of experiments run online (#4831). dataFileName assignment should come after addInfoFromUrl so that URL parameters (such as participant id) can be added to the filename.