Skip to content

ENH: If loading app windows with file causes error, try without #5696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

TEParsons
Copy link
Contributor

Stops users getting stuck in the position where they can't open the app because their last open experiment got mangled somehow.

@TEParsons TEParsons requested a review from peircej July 7, 2023 13:26
Copy link
Member

@peircej peircej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it would be good to get them the actual error message though or they won't be able to debug what has gone wrong (or provide us with good info). How about:

except Exception as err:
                # if Coder failed with file, try without
                logging.error(_translate(
                    "Failed to open Coder with requested scripts,opening with no scripts open. Requested: {}\n Err: {}"
                ).format(scripts, err))
                self.showCoder()

@TEParsons TEParsons requested a review from peircej July 7, 2023 15:35
@peircej peircej merged commit 3dc5980 into psychopy:dev Jul 24, 2023
@TEParsons TEParsons deleted the dev-safe-load branch August 31, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants