Fix VlcMovieStim #5702
Merged
Fix VlcMovieStim #5702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm comfortable pulling this in for now but what we're really wanting is for the ffpyplayer movies to be the single go-to movie player, rather than trying to support multiple solutions. Is that player not working for you? |
|
Last time I tried it seemed to have problems with larger movie files (audio/video not synced). Also, it still says "This movie class is very efficient and better suited for playing high-resolution videos (720p+) than the other movie classes." in the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, VlcMovieStim segfaults for me (tested on Win 10, Win 11, Ubuntu 22..10 and latest Linux Mint) when playing a movie. I don't really have time to investigate atm, but increasing the ref count seems to fix the problem.