Minor Textbox bugfixes #5723
Merged
Minor Textbox bugfixes #5723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when size and textgrid_shape were both None, there would be a crash. I fixed this by detecting when both were none and setting textgrid_shape to len(text) by 1, thus solving the issue. I also fixed a problem where size was too small, which caused textgrid.py to crash. I added a check to make sure the size wouldn't lead to an integer division error. Instead, if the size is not large enough (e.g. would cause an error), a ValueError is raised which tells the user to increase the size or use the textgrid_shape option.
Added AttributeError to exception on final case in textgrid.py. Previously this would cause an additional error message to trump the ValueError raised when size is too small.
|
The ultimate goal is to bring the speed of TextBox2 up to match TextBox so that we can remove TextBox altogether, but in the meantime these fixes seem a good stop gap :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when
sizeandtextgrid_shapewere bothNone, the program would crash. I fixed this by settingtextgrid_shapeto(len(text),1)when both areNone.I also fixed a
textgrid.pycrash caused bysizebeing too small to render a single character. AValueErroris now raised which tells the user to increase the size or use thetextgrid_shapeoption.Finally, I added
AttributeErrorto the exceptions of__del__intextgrid.py. Previously this would cause an additional error message whenevertextgrid.pyraised an error which makes actual problems difficult to detect.P.S. I got to TextBox via looking for rendering improvements for TextBox2. TextBox is much faster when drawing multiple instances. I plan on continuing my tinkering with TextBox2, but figured these quick bug fixes would be useful in the meantime.