Skip to content

NF: Counterbalance Component and Python implementation of Shelf #5967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TEParsons merged 33 commits into from
Oct 26, 2023
Merged

NF: Counterbalance Component and Python implementation of Shelf #5967

TEParsons merged 33 commits into from
Oct 26, 2023

Conversation

@TEParsons
Copy link
Contributor

@TEParsons TEParsons commented Oct 23, 2023

No description provided.

TEParsons and others added 29 commits October 4, 2023 17:30
FF: Allow table ctrl to work with Routine panels
8a5e221
NF: Counterbalance component
021f55f
@TEParsons
FF: BeginRoutineJS takes an additional argument
da92c25
@TEParsons
FF: Wrap counterbalance code in a function
cd7f961
@TEParsons
RF: Assume presence of data.Counterbalancer.allocateGroup method in JS
dece32a
@TEParsons
NF: Python Shelf (needs methods)
7367f44
@TEParsons
NF: Python Counterbalancer object
778a51a
@TEParsons
NF: Python implementation of CounterbalanceRoutine
e178d4e
@TEParsons
NF: Counterbalance function for Python Shelf
500aa62
@TEParsons
FF: Fixes to Python counterbalancer
1b85d95
@TEParsons
FF: Indent JSON for readability and enforce string keys
a6d1ba6
@TEParsons
ENH: Convenience method for getting shelf entry from Counterbalancer
7371461
@TEParsons
ENH: Allow wrap to split words if one word is longer than line
eb2ce02
@TEParsons
RF: Counterbalance should just be one word
c3ec154
@TEParsons
ENH: Split Counterbalance component label after Counter-
55dce21
@TEParsons
FF: Make sure counterbalance weights always sum to 1
40a1c43
@TEParsons
ENH: Clearer name for participant cap when group dist is uniform
25099e8
@TEParsons
ENH: Allow Counterbalancer conditions to be set as a variable name
f31623d
@TEParsons
ENH: Add Counterbalancer.finished (returns True when all groups deple…
8c879e5 
…ted)
@TEParsons
FF: Calculate weights from group sizes rather than requiring in spec
9fef385
@TEParsons
FF: We still need to ensure weights sum to 1
ef3137f
@TEParsons
ENH: Control behaviour for when Counterbalancer is finished
6dd1177
@TEParsons
FF: Don't error on choosing group if counterbalancing is finished
c4af344
@TEParsons
RF: Make Counterbalancer object just once per Routine
5242031
@TEParsons
ENH: Params for saving data from Counterbalance comp
0970df5
@TEParsons
FF: Cap reset wasn't saving
5292be2
@TEParsons
ENH: Boilerplate to get conds from variable
8c43ef1
@TEParsons
ENH: Pass onFinished command to PsychoJS Counterbalancer
7531dbf
@TEParsons
ENH: Save Counterbalancer data in JS
cf679ed
@TEParsons TEParsons mentioned this pull request Oct 23, 2023
Closed
@TEParsons
Copy link
Contributor Author

TEParsons commented Oct 23, 2023

Task linked: CU-8692uzc0q CounterBalance Component for Builder

@TEParsons TEParsons requested a review from peircej October 23, 2023 17:42
@TEParsons TEParsons merged commit 4ff2d9f into psychopy:dev Oct 26, 2023
@peircej peircej added the 🌟 enhancement Proposed improvement or feature request. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peircej peircej Awaiting requested review from peircej

Assignees

No one assigned

Labels

🌟 enhancement Proposed improvement or feature request.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TEParsons @peircej