Skip to content

Conversation

@mdcutone
Copy link
Member

This bug comes up when resizing the coder window. Since there is no SetMinSize call, the window can be resized to (-1. -1). The app will raise an unhandled exception, and the AUI perspective will be invalid. The coder window cannot be resized since it will always raise an error when the user attempts to resize it. If the app is closed, the invalid AUI layout will be saved and loaded next startup. This will crash the app since it is invalid, preventing the app from making it past the splash screen.

This fixes the issue by ensuring SetMinSize() is always called to prevent the window from being size too small in the first place. The second modification catches the error and manually sets up the window. This should generalize to other AUI perspective errors, allowing the app to get a fresh, default layout on any error.

@codecov
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #6192 (3fc0ec8) into dev (7e3c09a) will decrease coverage by 0.01%.
Report is 4 commits behind head on dev.
The diff coverage is 19.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6192      +/-   ##
==========================================
- Coverage   43.36%   43.35%   -0.01%     
==========================================
  Files         334      334              
  Lines       61464    61481      +17     
==========================================
+ Hits        26651    26657       +6     
- Misses      34813    34824      +11     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons
Copy link
Contributor

Task linked: CU-2f9cve0 AUI frame manager error

@TEParsons TEParsons merged commit 9c47255 into psychopy:dev Jan 26, 2024
@peircej peircej added the 🐞 bug Issue describes a bug (crash or error) or undefined behavior. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Issue describes a bug (crash or error) or undefined behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants