ENH: Catch fails in Packages dialog #6193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #6193 +/- ##
==========================================
- Coverage 43.36% 43.35% -0.02%
==========================================
Files 334 334
Lines 61462 61498 +36
==========================================
+ Hits 26651 26660 +9
- Misses 34811 34838 +27
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if one version number from a package can't be parsed by packaging.version.Version, it raises an error. This tries a few workarounds which can take a decent guess at the version number, and fails without error otherwise