Skip to content

BF: Fixed iohub keyboard input loss after eyetracker calibration#6226

Merged
peircej merged 1 commit intopsychopy:devfrom
mdcutone:dev-bf-eyetracker-issues
Feb 12, 2024
Merged

BF: Fixed iohub keyboard input loss after eyetracker calibration#6226
peircej merged 1 commit intopsychopy:devfrom
mdcutone:dev-bf-eyetracker-issues

Conversation

@mdcutone
Copy link
Member

@mdcutone mdcutone commented Feb 9, 2024

Removes the calibration._unregisterEventMonitors() call which unhooks input monitoring and makes the experiment unresponsive after eyetracker calibration is complete.

@codecov
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Merging #6226 (9808929) into dev (62d6beb) will increase coverage by 9.46%.
Report is 68 commits behind head on dev.
The diff coverage is 33.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6226      +/-   ##
==========================================
+ Coverage   41.82%   51.28%   +9.46%     
==========================================
  Files         334      334              
  Lines       61523    61625     +102     
==========================================
+ Hits        25730    31607    +5877     
+ Misses      35793    30018    -5775     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@peircej peircej merged commit 9808929 into psychopy:dev Feb 12, 2024
@peircej peircej added the 🐞 bug Issue describes a bug (crash or error) or undefined behavior. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Issue describes a bug (crash or error) or undefined behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants