RF: Supply end message from Builder rather than relying on JS default#6258
Merged
TEParsons merged 1 commit intopsychopy:devfrom Jul 1, 2024
Merged
RF: Supply end message from Builder rather than relying on JS default#6258TEParsons merged 1 commit intopsychopy:devfrom
TEParsons merged 1 commit intopsychopy:devfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #6258 +/- ##
=======================================
Coverage 51.79% 51.79%
=======================================
Files 334 334
Lines 61665 61666 +1
=======================================
+ Hits 31940 31941 +1
Misses 29725 29725
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In draft as this needs the accompanying change in PsychoJS (otherwise the end message becomes "Thank you for your patience." twice)