BF: Selecting audio device in builder and coder (fixes #6142) #6299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #6299 +/- ##
==========================================
- Coverage 51.88% 51.88% -0.01%
==========================================
Files 334 334
Lines 61677 61679 +2
==========================================
- Hits 32003 32002 -1
- Misses 29674 29677 +3
|
|
We marked as fixed because the audio device can now be specified in the Sound component itself, the pref is only used as a backup now, but didn't realise the pref was breaking the dialog! Thanks for finding & fixing this - I pulled down your branch to test and all seems fine. |
peircej
added
the
🐞 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PsychoPy Versions
2023.2.3, release, dev
Apparently in 2022.2.5 version it worked. The bug was introduced afterwards.
What OSes is your PsychoPy running on?
Ubuntu-20.4, Windows 10
Bug Description
This patch fixes an issue where selecting an audio device in PsychoPy Builder preferences is not being saved correctly. There is no way to change the audio device but to manually edit the user configuration.
This same issue has been described here before:
This was closed believing it is fixed in 2024.1.0/dev, but it is not.
Solution
audioDevicepreference must be alistfor the PsychoPy's internal settings validation to pass. This fixes the Apply and OK buttons.self.audioDevDefaultis updated to reflect the newly selected audio device, allowing the Apply button to function correctly.This change allows the audio device to be correctly selected, saved, and utilized in experiments.