Skip to content

BF: Fix bug where local PsychoJS server kept running after quitting#6323

Merged
TEParsons merged 1 commit intopsychopy:devfrom
TEParsons:dev-bf-kill-server
Mar 13, 2024
Merged

BF: Fix bug where local PsychoJS server kept running after quitting#6323
TEParsons merged 1 commit intopsychopy:devfrom
TEParsons:dev-bf-kill-server

Conversation

@TEParsons
Copy link
Contributor

We were killing it on a re-run of experiments, but not on the app closing. This fix also moves the starting and killing server code to their own functions so we only have to change it in one place, and keeps track of the port so that we can print when the server is closed (useful for debugging)

@TEParsons TEParsons requested a review from peircej March 13, 2024 12:06
@codecov
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Merging #6323 (bcd9967) into dev (b8c07a3) will decrease coverage by 0.01%.
Report is 36 commits behind head on dev.
The diff coverage is 20.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6323      +/-   ##
==========================================
- Coverage   51.87%   51.87%   -0.01%     
==========================================
  Files         334      335       +1     
  Lines       61679    61711      +32     
==========================================
+ Hits        31997    32012      +15     
- Misses      29682    29699      +17     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons merged commit ea9aff4 into psychopy:dev Mar 13, 2024
@TEParsons TEParsons deleted the dev-bf-kill-server branch April 22, 2024 09:42
@peircej peircej added the 🐞 bug Issue describes a bug (crash or error) or undefined behavior. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Issue describes a bug (crash or error) or undefined behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants