Skip to content

Conversation

@aforren1
Copy link
Contributor

@aforren1 aforren1 commented May 8, 2024

In a non-Builder context, the MovieStim's state is not updated, and .play() would subsequently be called on every .draw() call. On a test 4K video, this change saves ~6ms per call to .draw().

See #6439 for context.

In a non-Builder context, the MovieStim's state is not updated, and
`.play()` would subsequently be called on every `.draw()` call.
@codecov
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.63%. Comparing base (13eb353) to head (5d1e515).
Report is 65 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #6448      +/-   ##
===========================================
- Coverage    51.31%   41.63%   -9.69%     
===========================================
  Files          335      335              
  Lines        61857    61863       +6     
===========================================
- Hits         31745    25757    -5988     
- Misses       30112    36106    +5994     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@peircej peircej merged commit 06e747c into psychopy:release May 9, 2024
@peircej peircej added the 🐞 bug Issue describes a bug (crash or error) or undefined behavior. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Issue describes a bug (crash or error) or undefined behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants