ENH: Speed-up MovieStim (noticeable for larger videos)#6449
Merged
Conversation
Applies to the ffpyplayer backend of MovieStim. This saves a copy, as long as the frame remains alive while we use the data.
Various sources suggest that BGRA is preferred by the graphics hardware
TEParsons
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6439 for context. With my AMD+Ubuntu 22.04 laptop and this sample video, I get an overall reduction in
MovieStim.draw()time (starting from this patch) from ~34ms to ~4ms (i.e. ~40ms -> 4ms across both sets of patches). I haven't tested on other systems yet, but will try on a Windows 11 + Intel and Ubuntu 20.04 + AMD desktop today.