BF: KeyboardComponent allowed keys from spreadsheet caused namespace errors #6458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Spotted by this forum user |
peircej
added
the
🐞 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's because of local vs global namespaces - the variables from the spreadsheet are defined globally, but because the allowedKeys code in a Keyboard Component can set the variable (when it converts it to a tuple or does eval or etc.) and because the run code is now in a function, Python reserves the local name and so if you reference it you get "Variable not defined" (even though it's in globals).
This fixes it by saying that, if the same conditions under which the allowedKeys code is written is True, add some code to the start of the Routine to use the global variable's value for the undefined local variable.