Skip to content

BF: hide that visible mouse, please#6465

Merged
TEParsons merged 1 commit into
psychopy:releasefrom
mh105:visible_mouse
May 16, 2024
Merged

BF: hide that visible mouse, please#6465
TEParsons merged 1 commit into
psychopy:releasefrom
mh105:visible_mouse

Conversation

@mh105

@mh105 mh105 commented May 16, 2024

Copy link
Copy Markdown
Contributor

This problem has been around for a while that the mouse stays visible despite people being in fullscreen and unchecking the "Show Mouse" box. I think the culprit is here:

self.win.setMouseVisible(visible)

For some reason whenever we draw some visual objects, there is a logic in draggable() to create a new mouse with default visible=True, therefore overriding win.mouseVisible no matter how many times people try to set it to False manually.

This PR provides a simple fix.

@peircej peircej requested a review from TEParsons May 16, 2024 09:44
@TEParsons

Copy link
Copy Markdown
Contributor

Good catch! I think we can even go one step further and set up a default at the Mouse level - I'll pull this in and then make a follow up PR :)

@TEParsons TEParsons merged commit 39106af into psychopy:release May 16, 2024
@mh105 mh105 deleted the visible_mouse branch May 17, 2024 17:32
@peircej peircej added the 🐞 bug Issue describes a bug (crash or error) or undefined behavior. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Issue describes a bug (crash or error) or undefined behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants