BF: hide that visible mouse, please#6465
Merged
Merged
Conversation
Contributor
|
Good catch! I think we can even go one step further and set up a default at the Mouse level - I'll pull this in and then make a follow up PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem has been around for a while that the mouse stays visible despite people being in fullscreen and unchecking the "Show Mouse" box. I think the culprit is here:
psychopy/psychopy/event.py
Line 838 in 7969ebb
For some reason whenever we draw some visual objects, there is a logic in
draggable()to create a new mouse with defaultvisible=True, therefore overridingwin.mouseVisibleno matter how many times people try to set it toFalsemanually.This PR provides a simple fix.