BF: take into account that speaker index could jump over integers #6559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Although when I accidentally triggered the error logging, I noticed that it shows up in stdout as DEPRECATED instead of ERROR. Perhaps I shouldn't be using |
Contributor
|
I think DEPRECATED rather than ERROR is a bug in how Runner/Coder display log messages, probably because the constants DEPRECATED and ERROR have the same value. |
Contributor
Author
|
Sounds good. Could you merge this when you get a chance? It'll fix the indexing issue I introduced in the previous PR. Thanks! |
peircej
added
the
🐞 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a logging error warning in #6538 if the specified speaker index is out of bounds, but I forgot to consider that the indices may skip numbers so they could exceed the length of
profiles. This BF usesnot ina list comprehension to get around that. Sorry about that!