BF: Fixed crash when mono is specified if the microphone device supports stereo as default#6564
Merged
TEParsons merged 2 commits intopsychopy:releasefrom Jun 14, 2024
Merged
Conversation
peircej
added
the
🐞 bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds checks to mic settings to ensure they are compatible with the default for the mic. If not, we try and find a device config that does match those settings. If that doesn't work, we override the user settings with a warning to allow the program to continue, using the default mic settings recommended by the audio library.
It might be best to either grey out the mic settings when default is specified, or ensure that we are always getting the default mic and only populating fields with valid values associated with it.