Skip to content

DOC: make a note that writeRoutineEndCode does not save onset/offset times#6571

Merged
TEParsons merged 1 commit intopsychopy:releasefrom
mh105:release-saveStartStop
Jun 21, 2024
Merged

DOC: make a note that writeRoutineEndCode does not save onset/offset times#6571
TEParsons merged 1 commit intopsychopy:releasefrom
mh105:release-saveStartStop

Conversation

@mh105
Copy link
Contributor

@mh105 mh105 commented Jun 15, 2024

I noticed this while working on some other things for SoundComponent, but it looks like the writeRoutineEndCode() method of BaseComponent doesn't actually write code when generating scripts from Builder to save onset/offset times at the end of a routine. Is this expected...? It's just that almost all components have this parameter, and it was surprising there isn't corresponding code gets written for it. I apologize in advance if this is mistaken, and feel free to close it.

@TEParsons TEParsons merged commit 1dab24f into psychopy:release Jun 21, 2024
@mh105
Copy link
Contributor Author

mh105 commented Jun 21, 2024

@TEParsons Sorry is it correct that this part doesn't write any code...? Just want to make sure toggling the option of Save Onset/Offset Time under the Data tab does have an effect as intended. Perhaps it is now handled using a different mechanism using self.params['saveStartStop'] without adding a code section into the generated script? An example use is found here: I couldn't confirm whether that line has no effect whatsoever at the moment, so I just want to double check with you.

@mh105 mh105 deleted the release-saveStartStop branch July 5, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants