DOC: make a note that writeRoutineEndCode does not save onset/offset times#6571
Merged
TEParsons merged 1 commit intopsychopy:releasefrom Jun 21, 2024
Merged
Conversation
Contributor
Author
|
@TEParsons Sorry is it correct that this part doesn't write any code...? Just want to make sure toggling the option of Save Onset/Offset Time under the Data tab does have an effect as intended. Perhaps it is now handled using a different mechanism using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this while working on some other things for
SoundComponent, but it looks like thewriteRoutineEndCode()method ofBaseComponentdoesn't actually write code when generating scripts from Builder to save onset/offset times at the end of a routine. Is this expected...? It's just that almost all components have this parameter, and it was surprising there isn't corresponding code gets written for it. I apologize in advance if this is mistaken, and feel free to close it.