BF: Add default duration to eyetracker record component#6599
BF: Add default duration to eyetracker record component#6599TEParsons merged 1 commit intopsychopy:devfrom
Conversation
Eyetracker Record component needs duration in order to stop - so adding a duration value by default.
|
I think this is also fixed by #6567 - which adds a "stop with Routine" parameter. But having a default stop time doesn't conflict so happy for both to happen (just trying to get tests passing on the other one) |
|
Sorry @RebeccaHirst @TEParsons: This PR is already merged so my comment might be too late. But I don't know if the change here actually has the intended effect. Isn't the default duration of the |
|
Ah, I didn't realise - I thought you'd added a default for duration. Yes, duration estim is (or at least, should) only be used in the UI, the experiment shouldn't be affected |
|
Might make sense to revert so that users are not confused by why estimated duration defaults to 1s. But more importantly does the experiment actually halt when |
|
The only thing I can think is maybe it's leading to the routine being marked as non-slip falsely? Will investigate on Monday |
Eyetracker Record component needs duration in order to stop - so adding a duration value by default so users do not get confused why the experiment halts at the stop record.