Skip to content

NF: Add "force nonslip" param to Routine Settings#6603

Merged
TEParsons merged 2 commits intopsychopy:devfrom
TEParsons:dev-nf-routine-object
Jun 24, 2024
Merged

NF: Add "force nonslip" param to Routine Settings#6603
TEParsons merged 2 commits intopsychopy:devfrom
TEParsons:dev-nf-routine-object

Conversation

@TEParsons
Copy link
Contributor

No description provided.

@TEParsons TEParsons requested a review from peircej June 21, 2024 15:39
@TEParsons
Copy link
Contributor Author

@peircej could you check this over? I think this works as expected (from testing just now) but the concept of non-slip is kind of a headache at the best of times so would really appreciate a second pair of eyes on this

@codecov
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.26%. Comparing base (166c07a) to head (26f862d).
Report is 59 commits behind head on dev.

Current head 26f862d differs from pull request most recent head 4e6e647

Please upload reports for the commit 4e6e647 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #6603       +/-   ##
===========================================
- Coverage   50.79%   40.26%   -10.53%     
===========================================
  Files         331      332        +1     
  Lines       60894    61048      +154     
===========================================
- Hits        30932    24582     -6350     
- Misses      29962    36466     +6504     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons merged commit 076bab9 into psychopy:dev Jun 24, 2024
@peircej peircej added the 🌟 enhancement Proposed improvement or feature request. label Jul 19, 2024
@TEParsons TEParsons deleted the dev-nf-routine-object branch July 24, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 enhancement Proposed improvement or feature request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants