Merged
Conversation
The dialog doesn't seem to be destroyed unless .Destroy() is explicitly called. This fixes behavior on Mac/Linux; Windows seemed to behave as expected prior to this change.
Other platforms don't seem sensitive to the order, but the original order leads to an assertion on the wx side.
peircej
added
the
🐞 bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things I noticed while using coder on Linux:
and flipping the enable/append order seems to resolve it.
Tested on Ubuntu 20.04, and doesn't seem to adversely affect behavior on Windows.