Skip to content

BF: Save mouse.corr for online studies#6701

Merged
TEParsons merged 1 commit into
psychopy:devfrom
RebeccaHirst:_fixMouseCorrectClickOnline
Jul 12, 2024
Merged

BF: Save mouse.corr for online studies#6701
TEParsons merged 1 commit into
psychopy:devfrom
RebeccaHirst:_fixMouseCorrectClickOnline

Conversation

@RebeccaHirst
Copy link
Copy Markdown
Contributor

Mouse.corr was not storing for online studies because the value fed into the correct field was being read as a string not a variable.

Similar to this fix. #6668

Previously was returning obj.contains is not a function because the value fed into the correct field needs to be interpreted as the name of an object not a string.

Previously was returning obj.contains is not a function because the value fed into the correct field needs to be interpreted as the name of an object not a string.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.96%. Comparing base (f4b597e) to head (17c0488).
Report is 87 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6701      +/-   ##
==========================================
+ Coverage   41.15%   48.96%   +7.81%     
==========================================
  Files         332      332              
  Lines       61121    61168      +47     
==========================================
+ Hits        25152    29949    +4797     
+ Misses      35969    31219    -4750     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons merged commit 2cfadef into psychopy:dev Jul 12, 2024
@peircej peircej added the 🐞 bug Issue describes a bug (crash or error) or undefined behavior. label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Issue describes a bug (crash or error) or undefined behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants