Skip to content

FF: Fix opacity not applying properly to border colors#6704

Merged
TEParsons merged 2 commits into
psychopy:devfrom
TEParsons:dev-ff-border-col
Jul 12, 2024
Merged

FF: Fix opacity not applying properly to border colors#6704
TEParsons merged 2 commits into
psychopy:devfrom
TEParsons:dev-ff-border-col

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

Opacity is already between 0 and 1, so doesn't need to be transformed to fit with an rgba1 color scheme

@TEParsons TEParsons requested a review from mdcutone July 12, 2024 12:41
@TEParsons TEParsons changed the title FF: Opacity doesn't need transforming to rgb1 FF: Fix opacity not applying properly to border colors Jul 12, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.14%. Comparing base (f4b597e) to head (a8321ef).
Report is 95 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6704      +/-   ##
==========================================
- Coverage   41.15%   41.14%   -0.01%     
==========================================
  Files         332      332              
  Lines       61121    61140      +19     
==========================================
+ Hits        25152    25155       +3     
- Misses      35969    35985      +16     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons merged commit eda30aa into psychopy:dev Jul 12, 2024
@TEParsons TEParsons deleted the dev-ff-border-col branch July 14, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant