BF/RF: Code to load Builder-relevant entry points was broken and obsolete#6717
Merged
TEParsons merged 2 commits intopsychopy:devfrom Jul 17, 2024
Merged
BF/RF: Code to load Builder-relevant entry points was broken and obsolete#6717TEParsons merged 2 commits intopsychopy:devfrom
TEParsons merged 2 commits intopsychopy:devfrom
Conversation
added 2 commits
July 15, 2024 17:38
…ints are now loaded by activatePlugins
peircej
added
the
🐞 bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original bug is that
loadPluginBuilderElements(a function I wrote a while back) called load on the wrong object and so failed to load the entry points, logging an error but seemingly not breaking anything. The reason it didn't break anything is that the function is completely obsolete - all it does is load builder-relevant entry points, but all psychopy-relevant entry points are loaded inactivatePluginsalready. So this PR now just removes that function.