BF: Set MovieComponent.status to FINISHED when playback finishes#6740
Merged
TEParsons merged 2 commits intopsychopy:releasefrom Jul 24, 2024
Merged
BF: Set MovieComponent.status to FINISHED when playback finishes#6740TEParsons merged 2 commits intopsychopy:releasefrom
TEParsons merged 2 commits intopsychopy:releasefrom
Conversation
TEParsons
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like a SoundComponent, movieComponent should also log the stopping time by using the new
extra=argument towriteStopTestCode()that @TEParsons and I added.Also, the parameter update block in the writeFrameCode() needs to occur before the other blocks (such as
.play()), otherwise we see one frame that's not following the per-frame update rule.