Skip to content

BF: TrialHandler2 was starting thisRepsN at 1 rather than 0#6747

Merged
TEParsons merged 2 commits intopsychopy:releasefrom
TEParsons:release-bf-trialhandler-thisn
Jul 26, 2024
Merged

BF: TrialHandler2 was starting thisRepsN at 1 rather than 0#6747
TEParsons merged 2 commits intopsychopy:releasefrom
TEParsons:release-bf-trialhandler-thisn

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

Also added a test to make sure the indexing style remains the same for TrialHandler2 as it was for TrialHandler (at least for as long as there are two classes)

@mh105
Copy link
Copy Markdown
Contributor

mh105 commented Jul 25, 2024

FAILED psychopy/tests/test_data/test_TrialHandler2.py::TestTrialHandler2::test_skipTrials_rewindTrials - AssertionError: Was expecting current trial to match all fields {'thisN': 4, 'thisRepN': 2, 'thisTrialN': 1, 'thisIndex': 1}, instead was {'type': 'trial_data', 'thisN': 4, 'thisRepN': 1, 'thisTrialN': 1, 'thisIndex': 1, 'data': {'foo': 2, 'bar': 3, 'thisN': 4, 'thisTrialN': 1, 'thisRepN': 1}} (different thisRepN)

Seems to be failing tests on thisRepN at the moment. Is it because of this line?

thisRepN=0,

@TEParsons
Copy link
Copy Markdown
Contributor Author

I think this is just that the tests were configured to expect nReps to start at 1, which makes sense as when we were adding TrialHandler2 to Builder we were checking the values using the tests... So just needs a few values changed in the exemplars

@TEParsons TEParsons merged commit c4b87b7 into psychopy:release Jul 26, 2024
@TEParsons TEParsons deleted the release-bf-trialhandler-thisn branch July 26, 2024 11:34
@mh105
Copy link
Copy Markdown
Contributor

mh105 commented Jul 26, 2024

Ah I see. You meant the answer keys need to get updated. Thanks so much @TEParsons for the prompt BFs on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants