Skip to content

BF: DlgFromDict was erroneously adding keys when given "order" or "fixed"#6818

Merged
TEParsons merged 2 commits intopsychopy:releasefrom
TEParsons:release-bf-dlg-inplace
Sep 4, 2024
Merged

BF: DlgFromDict was erroneously adding keys when given "order" or "fixed"#6818
TEParsons merged 2 commits intopsychopy:releasefrom
TEParsons:release-bf-dlg-inplace

Conversation

@TEParsons
Copy link
Contributor

Fixes #6808

The cause of the bug was that I'd tried to use pipe syntax where possible to avoid doing the same thing twice in different places, but this meant adding characters to the dict keys in the case of order and fixed when we didn't need to.

@codecov
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.61%. Comparing base (c9c5010) to head (60088ec).
Report is 6 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #6818      +/-   ##
===========================================
+ Coverage    49.04%   49.61%   +0.56%     
===========================================
  Files          332      332              
  Lines        61155    61167      +12     
===========================================
+ Hits         29996    30348     +352     
+ Misses       31159    30819     -340     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons merged commit 23414c1 into psychopy:release Sep 4, 2024
@TEParsons TEParsons deleted the release-bf-dlg-inplace branch October 4, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant