FF: allow PipeReader to read from overflowBuffer promptly#6833
Merged
peircej merged 1 commit intopsychopy:releasefrom Sep 6, 2024
Merged
FF: allow PipeReader to read from overflowBuffer promptly#6833peircej merged 1 commit intopsychopy:releasefrom
peircej merged 1 commit intopsychopy:releasefrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release #6833 +/- ##
========================================
Coverage 49.61% 49.61%
========================================
Files 332 332
Lines 61167 61173 +6
========================================
+ Hits 30348 30354 +6
Misses 30819 30819
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now if
stdoutgets crowded by multiple printouts, the_overflowBufferwill catch them during thePipeReader.run()method. However, the for-loop ofself._fdpipe.readlineis dependent on new lines being added to the pipe. This means leftover bytes from the_overflowBufferwon't print out correctly to the runner stdout panel until the next message is printed, which could be never - so they only get printed at termination of the experiment.This commit adds the ability to put the leftover bytes from
_overflowBufferinto_queueas soon as the_queueis freed up, by coupling it into theisAvailable()method. This behavior is much smoother, without adding much blocking, and is consistent with what the existing comment inPipeReader.run()says: