Skip to content

ENH: move winHandle.activate() to beginning of run()#6876

Merged
TEParsons merged 1 commit intopsychopy:releasefrom
mh105:release-winhandle-activate
Sep 26, 2024
Merged

ENH: move winHandle.activate() to beginning of run()#6876
TEParsons merged 1 commit intopsychopy:releasefrom
mh105:release-winhandle-activate

Conversation

@mh105
Copy link
Contributor

@mh105 mh105 commented Sep 25, 2024

Following #6874, we need to call win.winHandle.activate() at the beginning of run() instead of immediately before the first win.flip(). This is because certain custom code could also trigger the lost focus if the code gets inserted to Beginning of Experiment. This way the window is ensured to be on the foreground at the very beginning of an experiment.

@codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.63%. Comparing base (c1992f5) to head (9911f90).
Report is 3 commits behind head on release.

Additional details and impacted files
@@           Coverage Diff            @@
##           release    #6876   +/-   ##
========================================
  Coverage    49.62%   49.63%           
========================================
  Files          332      332           
  Lines        61208    61208           
========================================
+ Hits         30377    30380    +3     
+ Misses       30831    30828    -3     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@TEParsons TEParsons merged commit f537141 into psychopy:release Sep 26, 2024
@mh105 mh105 deleted the release-winhandle-activate branch October 29, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments