ENH: move winHandle.activate() to beginning of run()#6876
Merged
TEParsons merged 1 commit intopsychopy:releasefrom Sep 26, 2024
Merged
ENH: move winHandle.activate() to beginning of run()#6876TEParsons merged 1 commit intopsychopy:releasefrom
TEParsons merged 1 commit intopsychopy:releasefrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release #6876 +/- ##
========================================
Coverage 49.62% 49.63%
========================================
Files 332 332
Lines 61208 61208
========================================
+ Hits 30377 30380 +3
+ Misses 30831 30828 -3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #6874, we need to call
win.winHandle.activate()at the beginning ofrun()instead of immediately before the firstwin.flip(). This is because certain custom code could also trigger the lost focus if the code gets inserted toBeginning of Experiment. This way the window is ensured to be on the foreground at the very beginning of an experiment.