Skip to content

BF: Counterbalance Routine conditions file chooser wasn't updating the value properly#6892

Merged
peircej merged 1 commit intopsychopy:releasefrom
TEParsons:release-bf-table-ctrl
Oct 8, 2024
Merged

BF: Counterbalance Routine conditions file chooser wasn't updating the value properly#6892
peircej merged 1 commit intopsychopy:releasefrom
TEParsons:release-bf-table-ctrl

Conversation

@TEParsons
Copy link
Copy Markdown
Contributor

TableCtrl wasn't triggering the correct event when a file was chosen, so the value wasn't updated unless the user went and edited the value in the text field after choosing it. While loops use the same control type, they handle this manually so it was only affecting Counterbalance Routine

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.73%. Comparing base (cdc8df1) to head (cc6a9d3).
Report is 37 commits behind head on release.

Additional details and impacted files
@@             Coverage Diff             @@
##           release    #6892      +/-   ##
===========================================
+ Coverage    41.25%   50.73%   +9.48%     
===========================================
  Files          332      332              
  Lines        61211    61211              
===========================================
+ Hits         25252    31058    +5806     
+ Misses       35959    30153    -5806     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)

@peircej peircej merged commit 5a32c67 into psychopy:release Oct 8, 2024
@TEParsons TEParsons deleted the release-bf-table-ctrl branch November 29, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants