App failing to start on MacOS if all windows closed on last app close#6926
Merged
peircej merged 2 commits intopsychopy:releasefrom Oct 22, 2024
Merged
App failing to start on MacOS if all windows closed on last app close#6926peircej merged 2 commits intopsychopy:releasefrom
peircej merged 2 commits intopsychopy:releasefrom
Conversation
On macos, it's possible to close all windows without closing the app. If you then tried to start the app with user prefs set to open last frame it would hang because no window was opened.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release #6926 +/- ##
===========================================
+ Coverage 40.99% 50.55% +9.56%
===========================================
Files 332 332
Lines 61215 61217 +2
===========================================
+ Hits 25095 30951 +5856
+ Misses 36120 30266 -5854
|
peircej
changed the title
This was referenced Oct 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macos, it's possible to close all windows without closing the app. If you then tried to start the app with user prefs set to open last frame it would hang because no window was opened.