Skip to content

BF: Fixed ioHub process staying alive after crash#6938

Merged
peircej merged 4 commits into
psychopy:releasefrom
mdcutone:release-bf-iohub-intermittent-kb-error
Nov 21, 2024
Merged

BF: Fixed ioHub process staying alive after crash#6938
peircej merged 4 commits into
psychopy:releasefrom
mdcutone:release-bf-iohub-intermittent-kb-error

Conversation

@mdcutone

@mdcutone mdcutone commented Oct 23, 2024

Copy link
Copy Markdown
Member

This PR catches errors that come from the iohub server process and prints them instead of simply crashing. This is a WIP so the dev team can discuss this change before merging.

@mdcutone mdcutone requested a review from TEParsons October 23, 2024 21:09
@codecov

codecov Bot commented Oct 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.56%. Comparing base (6959a23) to head (f7d972b).
Report is 19 commits behind head on release.

Additional details and impacted files
@@           Coverage Diff            @@
##           release    #6938   +/-   ##
========================================
  Coverage    50.56%   50.56%           
========================================
  Files          332      332           
  Lines        61220    61220           
========================================
+ Hits         30954    30956    +2     
+ Misses       30266    30264    -2     
Components Coverage Δ
app ∅ <ø> (∅)
boilerplate ∅ <ø> (∅)
library ∅ <ø> (∅)
vm-safe library ∅ <ø> (∅)
---- 🚨 Try these New Features:

@mdcutone mdcutone changed the title BF: Catch and display ioHub errors instead of just crashing BF: Fixed ioHub process staying alive after crash Oct 28, 2024
@mdcutone

Copy link
Copy Markdown
Member Author

Added an atexit handler which shuts down any active connection when the program exits. This should also handle cases where the app exits abnormally

@mdcutone mdcutone marked this pull request as ready for review October 28, 2024 20:18
@peircej peircej merged commit 5e348c0 into psychopy:release Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants